Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix multi-platform pull test #2272

Merged
merged 1 commit into from Apr 4, 2018

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Apr 4, 2018

Remove architecture not included in buysbox image and ensures amd64 is included since it may already exist in the content store. (Using a separate namespace just for this test might be more difficult).

Remove architecture not included in image

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
@estesp estesp added this to the 1.1 milestone Apr 4, 2018
@estesp
Copy link
Member

estesp commented Apr 4, 2018

Well, that's exciting:

--- FAIL: TestImagePullAllPlatforms (5.63s)
	testing.go:730: race detected during execution of test

(and not even related to your change)

@codecov-io
Copy link

Codecov Report

Merging #2272 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2272   +/-   ##
======================================
  Coverage    41.1%   41.1%           
======================================
  Files          66      66           
  Lines        7768    7768           
======================================
  Hits         3193    3193           
  Misses       4070    4070           
  Partials      505     505
Flag Coverage Δ
#windows 41.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b3ea4...9f3db59. Read the comment docs.

@estesp
Copy link
Member

estesp commented Apr 4, 2018

How come test failures aren't forcing a travis failure? Fluke?

The command "if [ "$GOOS" = "linux" ]; then sudo PATH=$PATH GOPATH=$GOPATH TESTFLAGS_PARALLEL=1 make integration ; fi" exited with 2.

@dmcgowan
Copy link
Member Author

dmcgowan commented Apr 4, 2018

It looks like the race is something we should fix. Related to the client using the resolver in parallel, which seems to be using a shared cache variable for tokens. Let's get this merged and I will work on a fix for that in the next rc (client change only).

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 6c02c5c into containerd:master Apr 4, 2018
@dmcgowan dmcgowan deleted the fix-platform-pull-test branch September 10, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants