Adding a --load-kmods flag to the NVIDIA OCI hook #2794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the proper kernel mods might not be loaded when trying to
stand up a container with GPUs, resulting eg in the
nvidia-container-cli
command failing because
/dev/nvidia-modeset
wasn't around.There performance impact of having
nvidia-container-cli
check for kernelmodules being loaded every time is negligible.
Signed-off-by: Jean Rouge jer329@cornell.edu