Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a --load-kmods flag to the NVIDIA OCI hook #2794

Merged
merged 1 commit into from Nov 16, 2018

Conversation

wk8
Copy link
Contributor

@wk8 wk8 commented Nov 15, 2018

Otherwise the proper kernel mods might not be loaded when trying to
stand up a container with GPUs, resulting eg in the nvidia-container-cli
command failing because /dev/nvidia-modeset wasn't around.

There performance impact of having nvidia-container-cli check for kernel
modules being loaded every time is negligible.

Signed-off-by: Jean Rouge jer329@cornell.edu

Signed-off-by: Jean Rouge <jer329@cornell.edu>
@wk8
Copy link
Contributor Author

wk8 commented Nov 15, 2018

(as a side note, I suspect that @crosbymichael didn't hit that when writing/testing #2330 because he used https://github.com/NVIDIA/nvidia-docker on the same box beforehand - and nvidia-docker's runtime does load the mods)

@codecov-io
Copy link

Codecov Report

Merging #2794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2794   +/-   ##
=======================================
  Coverage   43.72%   43.72%           
=======================================
  Files         100      100           
  Lines       10734    10734           
=======================================
  Hits         4693     4693           
  Misses       5311     5311           
  Partials      730      730
Flag Coverage Δ
#linux 47.39% <ø> (ø) ⬆️
#windows 40.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c2f00...9088007. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

Thanks @wk8

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 44b90df into containerd:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants