Update Windows lcow differ to set NT VIRTUAL MACHINE\Virtual Machines SID #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
|
Here is the shim pr that can be used with this: microsoft/hcsshim#531 |
|
And here is the matching Docker PR until it switches to the Containerd snapshotters: moby/moby#38922 |
lowenna
reviewed
Mar 21, 2019
|
One minor nit, but LGTM |
lowenna
approved these changes
Mar 21, 2019
… SID For LCOW using the Virtual Machines SID for the shared read-only layers improves overall performance avoiding the need to set per VM access at runtime. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
jterry75
force-pushed
the
windows_lcow_vmgroup_access
branch
from
6332c0d
to
7361b19
Compare
Codecov Report
@@ Coverage Diff @@
## master #3119 +/- ##
==========================================
- Coverage 47.57% 40.46% -7.12%
==========================================
Files 93 74 -19
Lines 8590 9876 +1286
==========================================
- Hits 4087 3996 -91
- Misses 3776 5317 +1541
+ Partials 727 563 -164
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LCOW using the Virtual Machines SID for the shared read-only layers
improves overall performance avoiding the need to set per VM access at runtime.
Signed-off-by: Justin Terry (VM) juterry@microsoft.com