Add timeout for I/O waitgroups #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes containerd#3286 This and a combination of a couple Docker changes are needed to fully resolve the issue on the Docker side. However, this ensures that after processes exit, we still leave some time for the I/O to fully flush before closing. Without this timeout, the delete methods would block forever. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3361 +/- ##
==========================================
- Coverage 49.01% 45.08% -3.94%
==========================================
Files 102 113 +11
Lines 9886 12542 +2656
==========================================
+ Hits 4846 5654 +808
- Misses 4193 6032 +1839
- Partials 847 856 +9
Continue to review full report at Codecov.
|
crosbymichael
added a commit
to crosbymichael/docker
that referenced
this pull request
Jun 21, 2019
This is the second part to containerd/containerd#3361 and will help process delete not block forever when the process exists but the I/O was inherited by a subprocess that lives on. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jul 5, 2019
This is the second part to containerd/containerd#3361 and will help process delete not block forever when the process exists but the I/O was inherited by a subprocess that lives on. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> Upstream-commit: b5f28865efebb14c66d5580dfa7bf0634b5e3241 Component: engine
Closed
thaJeztah
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Sep 20, 2019
This is the second part to containerd/containerd#3361 and will help process delete not block forever when the process exists but the I/O was inherited by a subprocess that lives on. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit b5f2886) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Sep 23, 2019
This is the second part to containerd/containerd#3361 and will help process delete not block forever when the process exists but the I/O was inherited by a subprocess that lives on. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit b5f28865efebb14c66d5580dfa7bf0634b5e3241) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 34b31d0ee06d1fcbf9b94b34b130fbeaf65a83a8 Component: engine
crosbymichael
added a commit
to crosbymichael/containerd
that referenced
this pull request
Sep 26, 2019
Backport for containerd#3361 This and a combination of a couple Docker changes are needed to fully resolve the issue on the Docker side. However, this ensures that after processes exit, we still leave some time for the I/O to fully flush before closing. Without this timeout, the delete methods would block forever. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
burnMyDread
pushed a commit
to burnMyDread/moby
that referenced
this pull request
Oct 21, 2019
This is the second part to containerd/containerd#3361 and will help process delete not block forever when the process exists but the I/O was inherited by a subprocess that lives on. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> Signed-off-by: zach <Zachary.Joyner@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3286
This and a combination of a couple Docker changes are needed to fully
resolve the issue on the Docker side. However, this ensures that after
processes exit, we still leave some time for the I/O to fully flush
before closing. Without this timeout, the delete methods would block
forever.
Signed-off-by: Michael Crosby crosbymichael@gmail.com