Remove the process default ENV #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the change in containerd#3542 it breaks $PATH handling for images becuase our default spec always sets a PATH on the process's .Env. This removes the default and adds an Opt to add this back. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3551 +/- ##
==========================================
- Coverage 42.2% 42.19% -0.02%
==========================================
Files 127 127
Lines 13903 13905 +2
==========================================
- Hits 5868 5867 -1
- Misses 7149 7152 +3
Partials 886 886
Continue to review full report at Codecov.
|
|
I'll open the cherry pick for this post merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change in #3542 it breaks $PATH handling for images becuase our
default spec always sets a PATH on the process's .Env.
This removes the default and adds an Opt to add this back.
Signed-off-by: Michael Crosby crosbymichael@gmail.com