Pin to libseccomp 2.3.3 #3575
Merged
Pin to libseccomp 2.3.3 #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib seccomp 2.4 has huge performance regressions. This change pins to 2.3.3 where that is not an issue Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
seccom2.3
branch
from
d806788
to
b5f03ea
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3575 +/- ##
=======================================
Coverage 42.26% 42.26%
=======================================
Files 126 126
Lines 13881 13881
=======================================
Hits 5867 5867
Misses 7128 7128
Partials 886 886
Continue to review full report at Codecov.
|
|
LGTM |
|
do we need this in our packaging scripts as well? /cc @seemethere |
|
@thaJeztah not at the moment |
|
👍 thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib seccomp 2.4 has huge performance regressions.
This change pins to 2.3.3 where that is not an issue
Signed-off-by: Michael Crosby crosbymichael@gmail.com