Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshots: return error if readSnapshot fails #3819

Merged
merged 1 commit into from Nov 11, 2019

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Nov 11, 2019

Signed-off-by: Wei Fu fuweid89@gmail.com

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 11, 2019

Build succeeded.

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #3819 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
+ Coverage   41.98%   41.99%   +0.01%     
==========================================
  Files         130      130              
  Lines       14577    14577              
==========================================
+ Hits         6120     6122       +2     
+ Misses       7543     7542       -1     
+ Partials      914      913       -1
Flag Coverage Δ
#linux 45.44% <0%> (+0.01%) ⬆️
#windows 36.94% <0%> (ø) ⬆️
Impacted Files Coverage Δ
snapshots/storage/bolt.go 55.74% <0%> (ø) ⬆️
snapshots/btrfs/btrfs.go 58.29% <0%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1d088...843423e. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants