Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logrus instead of printf for warning #3890

Merged
merged 1 commit into from Dec 13, 2019

Conversation

estesp
Copy link
Member

@estesp estesp commented Dec 13, 2019

Minor nit follow-on to #3848

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 13, 2019

Build succeeded.

@codecov-io
Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #3890 into master will decrease coverage by 3.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3890      +/-   ##
==========================================
- Coverage   45.72%   42.31%   -3.41%     
==========================================
  Files         117      130      +13     
  Lines       11765    14689    +2924     
==========================================
+ Hits         5379     6216     +837     
- Misses       5462     7548    +2086     
- Partials      924      925       +1
Flag Coverage Δ
#linux 45.72% <ø> (ø) ⬆️
#windows 37.82% <ø> (?)
Impacted Files Coverage Δ
archive/tar_opts.go 58.82% <0%> (-12.61%) ⬇️
snapshots/native/native.go 42.42% <0%> (-10.27%) ⬇️
cio/io.go 46.47% <0%> (-8.53%) ⬇️
archive/tar.go 48.18% <0%> (-8.51%) ⬇️
metadata/snapshot.go 48.47% <0%> (-7.19%) ⬇️
metadata/containers.go 49.84% <0%> (-6.26%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
content/local/store.go 49.52% <0%> (-5.29%) ⬇️
metadata/images.go 57.41% <0%> (-4.97%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff91f22...fa62b6d. Read the comment docs.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 082f7e3 into containerd:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants