Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELEASES.md: update release status #4059

Merged
merged 1 commit into from Mar 6, 2020
Merged

RELEASES.md: update release status #4059

merged 1 commit into from Mar 6, 2020

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Feb 26, 2020 •
edited

  1. Update release status
  2. Add Extended state for release v1.2

Signed-off-by: Wei Fu fuweid89@gmail.com

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2020

Build succeeded.

Zyqsempai
Zyqsempai approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 26, 2020 •
edited

Codecov Report

Merging #4059 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4059      +/-   ##
==========================================
- Coverage   42.67%   42.53%   -0.15%     
==========================================
  Files         130      130              
  Lines       14778    14828      +50     
==========================================
  Hits         6307     6307              
- Misses       7552     7602      +50     
  Partials      919      919
Flag Coverage Δ
#linux 45.89% <ø> (-0.19%) ⬇️
#windows 38.22% <ø> (-0.05%) ⬇️
Impacted Files Coverage Δ
oci/spec_opts.go 34.79% <0%> (-0.4%) ⬇️
services/server/server.go 2.35% <0%> (-0.04%) ⬇️
oci/spec_opts_linux.go 0% <0%> (ø) ⬆️
runtime/v2/shim/util_unix.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4967b...8c9e841. Read the comment docs.

estesp
estesp approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Member

estesp commented Feb 26, 2020

I believe we want a quorum of maintainers to LGTM this as it changes support timeframes for a release? ping @containerd/containerd-maintainers

thaJeztah
thaJeztah approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Member

mikebrow commented Feb 27, 2020 •
edited

I suggest we keep the EOL date as is AND use the Extended option to support security updates through October. Why: k8s support is only latest and the last two (n-2) minor versions (just 6-9months) only exception is for some CVEs. Our response, so far, was to move up our support for k8s from k8s v1.12 to v1.14 and to support CVEs. See tables here https://github.com/containerd/cri#support-metrics Kubernetes is about to release 1.18, ... needless to say the model of punting our EOL down the road is problematic because of CRI's reliance on k8s support.

@fuweid
Copy link
Member Author

fuweid commented Mar 3, 2020 •
edited

Thanks! @mikebrow . Your suggestion LGTM. And I will update the pr with the following changes after March 26.

Release Status Start End of Life
1.2 Extended October 24, 2018 September 26, 2020

And do we need to put the start date for extended status? because the Start column is confusing

@mikebrow
Copy link
Member

mikebrow commented Mar 3, 2020 •
edited

Thanks! @mikebrow . Your suggestion LGTM. And I will update the pr with the following changes after March 26.

Release Status Start End of Life
1.2 Extended October 24, 2018 September 26, 2020
And do we need to put the start date for extended status? because the Start column is confusing

I was thinking we'd keep the end of life date unchanged and add a new date column for extended (past EOL) support entering N/A for the other releases. @dmcgowan @estesp thoughts?

@dmcgowan
Copy link
Member

dmcgowan commented Mar 3, 2020

When we extended 1.1 it looked like

Release Status Start End of Life
1.1 Active April 23, 2018 July 23, 2019 (Active), October 23, 2019 (Extended)

I think we could probably split the time to June 26th, 2020 (active), September 26th, 2020 (extended).

@mikebrow
Copy link
Member

mikebrow commented Mar 3, 2020

When we extended 1.1 it looked like

Release Status Start End of Life
1.1 Active April 23, 2018 July 23, 2019 (Active), October 23, 2019 (Extended)
I think we could probably split the time to June 26th, 2020 (active), September 26th, 2020 (extended).

SGTM

mxpv
mxpv approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
RELEASES.md: update release status
8c9e841 
1. Update release status
2. Add Extended state for release v1.2

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid force-pushed the me-upstream-release-status branch from c9deb2c to 8c9e841 Compare March 6, 2020 02:33
@fuweid
Copy link
Member Author

fuweid commented Mar 6, 2020

Updated PTAL @mikebrow @dmcgowan

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 6, 2020

Build succeeded.

thaJeztah
thaJeztah approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

mikebrow
mikebrow approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Member

estesp commented Mar 6, 2020

ping @dmcgowan and maybe @crosbymichael before we merge--looks like all active comments have been taken into account.

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit aac6a51 into containerd:master Mar 6, 2020
@fuweid fuweid mentioned this pull request Apr 10, 2020
Closed
@fuweid fuweid deleted the me-upstream-release-status branch April 22, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@Zyqsempai Zyqsempai Zyqsempai approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@fuweid @codecov-io @estesp @mikebrow @dmcgowan @crosbymichael @mxpv @thaJeztah @Zyqsempai @AkihiroSuda