Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seccomp: add 64-bit time_t syscalls #4124

Merged
merged 1 commit into from Mar 25, 2020

Conversation

thaJeztah
Copy link
Member

similar to moby/moby#40739

Relates to https://patchwork.kernel.org/patch/10756415/

Added to whitelist:

  • clock_getres_time64 (equivalent of clock_getres, which was whitelisted)
  • clock_gettime64 (equivalent of clock_gettime, which was whitelisted)
  • clock_nanosleep_time64 (equivalent of clock_nanosleep, which was whitelisted)
  • futex_time64 (equivalent of futex, which was whitelisted)
  • io_pgetevents_time64 (equivalent of io_pgetevents, which was whitelisted)
  • mq_timedreceive_time64 (equivalent of mq_timedreceive, which was whitelisted)
  • mq_timedsend_time64 (equivalent of mq_timedsend, which was whitelisted)
  • ppoll_time64 (equivalent of ppoll, which was whitelisted)
  • pselect6_time64 (equivalent of pselect6, which was whitelisted)
  • recvmmsg_time64 (equivalent of recvmmsg, which was whitelisted)
  • rt_sigtimedwait_time64 (equivalent of rt_sigtimedwait, which was whitelisted)
  • sched_rr_get_interval_time64 (equivalent of sched_rr_get_interval, which was whitelisted)
  • semtimedop_time64 (equivalent of semtimedop, which was whitelisted)
  • timer_gettime64 (equivalent of timer_gettime, which was whitelisted)
  • timer_settime64 (equivalent of timer_settime, which was whitelisted)
  • timerfd_gettime64 (equivalent of timerfd_gettime, which was whitelisted)
  • timerfd_settime64 (equivalent of timerfd_settime, which was whitelisted)
  • utimensat_time64 (equivalent of utimensat, which was whitelisted)

Not added to whitelist:

  • clock_adjtime64 (equivalent of clock_adjtime, which was not whitelisted)
  • clock_settime64 (equivalent of clock_settime, which was not whitelisted)

Signed-off-by: Sebastiaan van Stijn github@gone.nl

Relates to https://patchwork.kernel.org/patch/10756415/

Added to whitelist:

- `clock_getres_time64` (equivalent of `clock_getres`, which was whitelisted)
- `clock_gettime64` (equivalent of `clock_gettime`, which was whitelisted)
- `clock_nanosleep_time64` (equivalent of `clock_nanosleep`, which was whitelisted)
- `futex_time64` (equivalent of `futex`, which was whitelisted)
- `io_pgetevents_time64` (equivalent of `io_pgetevents`, which was whitelisted)
- `mq_timedreceive_time64` (equivalent of `mq_timedreceive`, which was whitelisted)
- `mq_timedsend_time64 ` (equivalent of `mq_timedsend`, which was whitelisted)
- `ppoll_time64` (equivalent of `ppoll`, which was whitelisted)
- `pselect6_time64` (equivalent of `pselect6`, which was whitelisted)
- `recvmmsg_time64` (equivalent of `recvmmsg`, which was whitelisted)
- `rt_sigtimedwait_time64` (equivalent of `rt_sigtimedwait`, which was whitelisted)
- `sched_rr_get_interval_time64` (equivalent of `sched_rr_get_interval`, which was whitelisted)
- `semtimedop_time64` (equivalent of `semtimedop`, which was whitelisted)
- `timer_gettime64` (equivalent of `timer_gettime`, which was whitelisted)
- `timer_settime64` (equivalent of `timer_settime`, which was whitelisted)
- `timerfd_gettime64` (equivalent of `timerfd_gettime`, which was whitelisted)
- `timerfd_settime64` (equivalent of `timerfd_settime`, which was whitelisted)
- `utimensat_time64` (equivalent of `utimensat`, which was whitelisted)

Not added to whitelist:

- `clock_adjtime64` (equivalent of `clock_adjtime`, which was not whitelisted)
- `clock_settime64` (equivalent of `clock_settime`, which was not whitelisted)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 25, 2020

Build succeeded.

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #4124 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4124   +/-   ##
=======================================
  Coverage   42.43%   42.43%           
=======================================
  Files         129      129           
  Lines       14875    14875           
=======================================
  Hits         6312     6312           
  Misses       7644     7644           
  Partials      919      919           
Flag Coverage Δ
#linux 45.76% <ø> (ø)
#windows 38.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d4208...9529c69. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 214fbce into containerd:master Mar 25, 2020
@thaJeztah thaJeztah deleted the seccomp_time64 branch March 25, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants