Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic in shim is not logged #4298

Closed
wants to merge 1 commit into from
Closed

Conversation

milkwine
Copy link
Contributor

@milkwine milkwine commented Jun 3, 2020

#4274

The daemon log will be:

...
DEBU[2020-06-03T14:48:54.204864142+08:00] event forwarded                               ns=default topic=/tasks/create type=containerd.events.TaskCreate
DEBU[2020-06-03T14:48:54.225318724+08:00] event forwarded                               ns=default topic=/tasks/start type=containerd.events.TaskStart
panic: test20200520

goroutine 7 [running]:
github.com/containerd/containerd/runtime/v2/shim.Run.func1()
	/home/zsy/.asdf/installs/golang/1.13.5/packages/src/github.com/containerd/containerd/runtime/v2/shim/shim.go:151 +0x47
created by github.com/containerd/containerd/runtime/v2/shim.Run
	/home/zsy/.asdf/installs/golang/1.13.5/packages/src/github.com/containerd/containerd/runtime/v2/shim/shim.go:149 +0x47
INFO[2020-06-03T14:48:56.998794944+08:00] shim disconnected                             id=foo
WARN[2020-06-03T14:48:56.998935894+08:00] cleaning up after shim disconnected           id=foo namespace=default
INFO[2020-06-03T14:48:56.998989197+08:00] cleaning up dead shim                        
...

This pr has changed project containerd/fifo in vendor directory, because dup2 need to pass fd as param which hold by struct fifo.

Signed-off-by: SiYu Zhao <d.chaser.zsy@gmail.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 3, 2020

Build succeeded.

@milkwine
Copy link
Contributor Author

milkwine commented Jun 3, 2020

Need to open a PR in containerd/fifo first if we want this.

@AkihiroSuda
Copy link
Member

Could you open fifo PR?

@AkihiroSuda
Copy link
Member

cc @tonistiigi

@jterry75
Copy link
Contributor

@kevpar - Since it looks like this is going to be a fifo approach for windows, we will likely need the shim on Windows to re-log the panic.log file in the task's dir. This will need a follow up pr from the Windows side

@AkihiroSuda
Copy link
Member

ping @milkwine

@AkihiroSuda
Copy link
Member

@milkwine Are you still interested in this?

mxpv added a commit to mxpv/containerd that referenced this pull request Oct 26, 2020
Fix containerd#4274
Carry containerd#4298

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@AkihiroSuda
Copy link
Member

Carried as #4657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants