Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.3] Pin libseccomp to 2.3.3 for GH Actions release.yml #4352

Merged
merged 1 commit into from Jun 30, 2020

Conversation

estesp
Copy link
Member

@estesp estesp commented Jun 29, 2020

Use the same pinning we were using in Travis CI to not force
dependencies on the newer libseccomp 2.4.x in our binaries.

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

Fixes: #4349

@estesp
Copy link
Member Author

estesp commented Jun 29, 2020

Going to verify this in my "actions playground" before we commit

@estesp estesp changed the title Pin libseccomp to 2.3.3 for GH Actions release.yml [release/1.3] Pin libseccomp to 2.3.3 for GH Actions release.yml Jun 29, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2020

Build succeeded.

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Member

Assuming the playgrounds thing works :)

Use the same pinning we were using in Travis CI to not force
dependencies on the newer libseccomp 2.4.x in our binaries.

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@estesp
Copy link
Member Author

estesp commented Jun 29, 2020

Assuming the playgrounds thing works :)

It is now; forgot the working directory the first commit. Second time's a charm; actions release worked and binary is linked to 2.3.3 libseccomp.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2020

Build succeeded.

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit fc8f6c5 into containerd:release/1.3 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants