Add --cpu-quota, --cpu-period flag to ctr #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
AkihiroSuda
reviewed
Aug 5, 2020
cmd/ctr/commands/run/run_unix.go
Outdated
| @@ -220,6 +220,11 @@ func NewContainer(ctx gocontext.Context, client *containerd.Client, context *cli | |||
| if limit != 0 { | |||
| opts = append(opts, oci.WithMemoryLimit(limit)) | |||
| } | |||
| quota := context.Int64("cpu-quota") | |||
| period := context.Uint64("cpu-period") | |||
| if quota != -1 || period != 0 { | |||
There was a problem hiding this comment.
Let's add them near the context.Float64("cpus") line for readability
There was a problem hiding this comment.
Also should error out when --cpus is specified together
There was a problem hiding this comment.
thanks for your guide.
I move descriptions to near the cpus, and change to check if cpus is used, skip applying cpu-quota and cpu-period.
Signed-off-by: Kenneth Kang <kenneth.kang@lge.com>
AkihiroSuda
approved these changes
Aug 6, 2020
|
Build succeeded.
|
|
@AkihiroSuda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenneth Kang kenneth.kang@lge.com