Move proto format ci check to proto job #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
force-pushed
the
move-proto-fmt-ci
branch
from
0b5a408
to
2e6d7b9
Compare
|
Build succeeded.
|
mxpv
reviewed
Oct 8, 2020
.github/workflows/ci.yml
Outdated
| - name: Check fmt | ||
| working-directory: src/github.com/containerd/containerd | ||
| run: | | ||
| export PATH=$PATH:$(go env GOPATH)/bin |
There was a problem hiding this comment.
We already update PATH in Set env step above:
https://github.com/containerd/containerd/pull/4611/files#diff-e9f950f17198d3d5e3122a44230a09b9R137
I think this line should not be needed.
There was a problem hiding this comment.
Removed, let's see what ci says :)
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
move-proto-fmt-ci
branch
from
2e6d7b9
to
8b20ca9
Compare
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to lint change