New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to run node e2e tests #4627

Merged

estesp merged 1 commit into containerd:master from dmcgowan:test-add-tarball-check

Oct 19, 2020

Member

dmcgowan commented Oct 13, 2020

Running through tests first

k8s-ci-robot commented Oct 13, 2020

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Member Author

dmcgowan commented Oct 13, 2020

/test all

k8s-ci-robot commented Oct 13, 2020

@dmcgowan: No jobs can be run with /test all.
The following commands are available to trigger jobs:

/test pull-containerd-build
/test pull-containerd-node-e2e

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member Author

dmcgowan commented Oct 13, 2020

/test pull-containerd-build

Member Author

dmcgowan commented Oct 13, 2020

/test pull-containerd-node-e2e

theopenlab-ci bot commented Oct 13, 2020

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 00s (non-voting)

Member Author

dmcgowan commented Oct 14, 2020

/test pull-containerd-node-e2e

dmcgowan force-pushed the test-add-tarball-check branch from 5f08d18 to 25d641d Compare

October 14, 2020 00:43

Member Author

dmcgowan commented Oct 14, 2020

/test pull-containerd-node-e2e

theopenlab-ci bot commented Oct 14, 2020

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 04s (non-voting)

dmcgowan force-pushed the test-add-tarball-check branch from 25d641d to 83f4774 Compare

October 16, 2020 19:25

Member Author

dmcgowan commented Oct 16, 2020

/test pull-containerd-node-e2e

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 05s (non-voting)

dmcgowan force-pushed the test-add-tarball-check branch from 83f4774 to 29c55ac Compare

October 16, 2020 19:47

Member Author

dmcgowan commented Oct 16, 2020

/test pull-containerd-node-e2e

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 00s (non-voting)

dmcgowan force-pushed the test-add-tarball-check branch from 29c55ac to 283a717 Compare

October 16, 2020 20:03

Member Author

dmcgowan commented Oct 16, 2020

/test pull-containerd-node-e2e

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 54s (non-voting)


          Update DEPLOY_DIR and VERSION to match installation script

04a3f7c

Signed-off-by: Derek McGowan <derek@mcg.dev>

dmcgowan force-pushed the test-add-tarball-check branch from 283a717 to 04a3f7c Compare

October 16, 2020 20:33

Member Author

dmcgowan commented Oct 16, 2020

/test pull-containerd-node-e2e

theopenlab-ci bot commented Oct 16, 2020

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 58s (non-voting)

k8s-ci-robot commented Oct 16, 2020

@dmcgowan: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-containerd-node-e2e	`04a3f7c`	link	`/test pull-containerd-node-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Member

mikebrow commented Oct 16, 2020

Possible fix here kubernetes/kubernetes#95613 see kubernetes/kubernetes#95321

dmcgowan changed the title ~~Add tarball value check in test build~~ Fixes to run node e2e tests

dmcgowan marked this pull request as ready for review

October 16, 2020 21:38

mikebrow approved these changes

View reviewed changes

Member

mikebrow left a comment

LGTM

Member

mikebrow commented Oct 16, 2020 •

edited

we can merge this fix now imo.. the failures are not due to this PR or the merging of CRI into containerd.

Member

mikebrow commented Oct 16, 2020

/test

k8s-ci-robot commented Oct 16, 2020

@mikebrow: The /test command needs one or more targets.
The following commands are available to trigger jobs:

/test pull-containerd-build
/test pull-containerd-node-e2e

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member

mikebrow commented Oct 16, 2020

/test pull-containerd-build

mikebrow mentioned this pull request

turning on prow pre-submit jobs and build must pass kubernetes/test-infra#19612

Closed

Member

dims commented Oct 19, 2020

LGTM

estesp approved these changes

View reviewed changes

Member

estesp left a comment

LGTM

estesp merged commit f36f313 into containerd:master

dmcgowan deleted the test-add-tarball-check branch

April 20, 2024 00:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment