Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI security profile update for CRI graduation #4700

Merged
merged 3 commits into from Jan 12, 2021

Conversation

mikebrow
Copy link
Member

@mikebrow mikebrow commented Nov 6, 2020

Addressing new CRI api changes:

kubernetes/kubernetes#95876

@mrunalp @saschagrunert

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 7, 2020

Build succeeded.

@mikebrow mikebrow force-pushed the cri-security-profile-update branch 2 times, most recently from 16172c3 to 34e9ba2 Compare November 7, 2020 00:10
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 7, 2020

Build succeeded.

Copy link
Contributor

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 3, 2020

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 3, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 3, 2020

Build succeeded.

@mikebrow
Copy link
Member Author

mikebrow commented Dec 3, 2020

would be nice if it printed the diff:

  These files were modified: 
   M go.sum
  Error: Process completed with exit code 1.

go mod tidy cleared it up

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 4, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 8, 2020

Build succeeded.

@mikebrow
Copy link
Member Author

mikebrow commented Dec 8, 2020

@dmcgowan refactored, and ready for review.

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 550b494 into containerd:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants