Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode "amd64" on LCOW and Windows-related files #4707

Merged
merged 1 commit into from Nov 17, 2020

Conversation

kzys
Copy link
Member

@kzys kzys commented Nov 9, 2020

Fixes #3281.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

Fixes containerd#3281.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@k8s-ci-robot
Copy link

Hi @kzys. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar
Copy link
Member

kevpar commented Nov 9, 2020

I'm not a maintainer, but LGTM

@kzys
Copy link
Member Author

kzys commented Nov 16, 2020

@jterry75 Can you take a look?

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 340ab57 into containerd:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCOW: should not hard code "amd64" architecture
5 participants