Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install-runc: remove unused USESUDO variable #4718

Merged
merged 1 commit into from Nov 10, 2020
Merged

install-runc: remove unused USESUDO variable #4718

merged 1 commit into from Nov 10, 2020

Conversation

thaJeztah
Copy link
Member

This is no longer needed, as the script is already run with sudo (see 65df8db).

@thaJeztah
install-runc: remove unused USESUDO variable
1edeea7 
This is no longer needed, as the script is already run with sudo.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

@thaJeztah
Copy link
Member Author

Windows failure shouldn't be related;

--- FAIL: TestContentClient (11.25s)
    --- FAIL: TestContentClient/ResumeCopySeeker (1.54s)
Error:         testsuite.go:677: ref ContentClient-n1/1/ref-0-4 locked: unavailable
Error:         helpers.go:67: drwxrwxrwx          0 C:\Users\RUNNER~1\AppData\Local\Temp\content-suite-ContentClient-183030746

dims
dims approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 677aaad into containerd:master Nov 10, 2020
@thaJeztah thaJeztah deleted the remove_sudo_remnants branch November 10, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @crosbymichael @dims @AkihiroSuda