Add scratch space re-use functionality to LCOW snapshotter #4824
Conversation
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
Oh sorry. Can you fix the linter issue |
dcantah
force-pushed
the
dcantah/reuse-scratch
branch
from
fea304f
to
40c9087
Compare
|
Build succeeded.
|
|
@jterry75 hahah I'm on it. Thought it was coming from somewhere else |
dcantah
force-pushed
the
dcantah/reuse-scratch
branch
from
40c9087
to
eefb1f8
Compare
|
Build succeeded.
|
dcantah
force-pushed
the
dcantah/reuse-scratch
branch
from
eefb1f8
to
06457a4
Compare
|
Build succeeded.
|
|
@jterry75 Fixed... after three tries..... haha |
|
/ok-to-test |
|
@anmaxvl @kevpar @katiewasnothere @ambarve If anyone has some time to give this a skim today |
dcantah
force-pushed
the
dcantah/reuse-scratch
branch
from
06457a4
to
a84fb2e
Compare
|
Looks like the CI failed on a devmapper test which is surely unrelated to this. |
Same test has been failing for me on a separate PR so probably fine here |
dcantah
force-pushed
the
dcantah/reuse-scratch
branch
from
a84fb2e
to
5d7691f
Compare
|
@crosbymichael The loop device tests that are failing can be ignored for this right? Anything else needed to help get this in? |
Currently we would create a new disk and mount this into the LCOW UVM for every container but there are certain scenarios where we'd rather just mount a single disk and then have every container share this one storage space instead of every container having it's own xGB of space to play around with. This is accomplished by just making a symlink to the disk that we'd like to share and then using ref counting later on down the stack in hcsshim if we see that we've already mounted this disk. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
dcantah/reuse-scratch
branch
from
5d7691f
to
3e5acb9
Compare
|
Build succeeded.
|
|
@dmcgowan @crosbymichael Is there anything else needed for this? |
|
@dcantah I think it is good since you have LGTM from @katiewasnothere and @jterry75. |
Currently we would create a new disk and mount this into the LCOW UVM for every container but there
are certain scenarios where we'd rather just mount a single disk and then have every container share this one
storage space instead of every container having it's own xGB of space to play around with.
This is accomplished by just making a symlink to the disk that we'd like to share and then
using ref counting later on down the stack in hcsshim if we see that we've already mounted this
disk.
Signed-off-by: Daniel Canter dcanter@microsoft.com