script/setup: use git clone instead of go get -d #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... odd; is state not cleaned up between runs? |
|
@thaJeztah the |
|
ah, hm... will have to look a bit more in depth then how to best fix. |
estesp
force-pushed
the
fix_install_scripts
branch
2 times, most recently
from
567dfa1
to
b680121
Compare
`go get -d` uses go modules by default in Go 1.16 and up, which results in modules being fetched for the "latest" module version, after which we tried to "git checkout" to `<VERSION>`. For runc, this means that (possibly incorrectly), `go get` will download runc `v0.1.1` (most recent non-"pre-release", which caused failures (e.g the old `Sirupsen/logrus` being downloaded). In addition, some of the dependencies we're installing use vendoring, and thus would not require the modules to be downloaded (and vendored files will be ignored when using `go get` with modules). This patch switches several uses `go get -d` to use a regular git clone, after which the desired version is checked out, and the binaries are built. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Phil Estes <estesp@amazon.com>
estesp
force-pushed
the
fix_install_scripts
branch
from
b680121
to
1645738
Compare
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #5005
go get -duses go modules by default in Go 1.16 and up, which resultsin modules being fetched for the "latest" module version, after which we
tried to "git checkout" to
<VERSION>.For runc, this means that (possibly incorrectly),
go getwill downloadrunc
v0.1.1(most recent non-"pre-release", which caused failures (e.gthe old
Sirupsen/logrusbeing downloaded).In addition, some of the dependencies we're installing use vendoring, and
thus would not require the modules to be downloaded (and vendored files
will be ignored when using
go getwith modules).This patch switches several uses
go get -dto use a regulargit clone, after which the desired version is checked out,
and the binaries are built.