Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to Windows 20H2 test images. #5025

Merged
merged 1 commit into from Feb 12, 2021
Merged

Add references to Windows 20H2 test images. #5025

merged 1 commit into from Feb 12, 2021

Conversation

jeremyje
Copy link
Contributor

@jeremyje jeremyje commented Feb 9, 2021

No description provided.

@k8s-ci-robot
Copy link

Hi @jeremyje. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build succeeded.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like you forgot to sign-off the commit (it's missing a signed-off-by line in the commit message); https://github.com/containerd/project/blob/master/CONTRIBUTING.md#sign-your-work

Signed-off-by: Jeremy Edwards <1312331+jeremyje@users.noreply.github.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build succeeded.

@thaJeztah
Copy link
Member

Hmm.. looks like there's some flakiness in other tests (at least, doesn't look related to this PR);

--- FAIL: TestSnapshotterSuite (0.67s)
    --- FAIL: TestSnapshotterSuite/DevMapperUsage (0.66s)
        snapshotter_test.go:141: assertion failed: expression is false: layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize: 1179648 < 1179648
FAIL
FAIL	github.com/containerd/containerd/snapshots/devmapper	39.953s
ok  	github.com/containerd/containerd/snapshots/devmapper/dmsetup	0.639s
ok  	github.com/containerd/containerd/snapshots/native	7.604s
ok  	github.com/containerd/containerd/snapshots/overlay	15.367s
FAIL
Makefile:177: recipe for target 'root-test' failed
make: *** [root-test] Error 1
Error: Process completed with exit code 2.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyje
Copy link
Contributor Author

jeremyje commented Feb 9, 2021

/retest

@k8s-ci-robot
Copy link

@jeremyje: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thaJeztah
Copy link
Member

/ok-to-test

@thaJeztah
Copy link
Member

/retest

1 similar comment
@jeremyje
Copy link
Contributor Author

jeremyje commented Feb 9, 2021

/retest

@fuweid fuweid requested a review from kevpar February 10, 2021 23:09
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyje
Copy link
Contributor Author

How do I trigger that test to run again?

@jeremyje
Copy link
Contributor Author

/retest

1 similar comment
@jeremyje
Copy link
Contributor Author

/retest

@AkihiroSuda
Copy link
Member

@jeremyje "Re-run jobs" can be used for restarting GHA https://docs.github.com/en/actions/managing-workflow-runs/re-running-a-workflow

(I already clicked the button)

@thaJeztah
Copy link
Member

@AkihiroSuda I think that's only available for users with write access; at least, button doesn't show for me;

Screenshot 2021-02-12 at 12 24 26

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Feb 12, 2021

🤦‍♂️

Then the only available option would be to amend the commit message slightly and push...

@thaJeztah
Copy link
Member

Let me try if closing/re-opening still works as a workaround.

@thaJeztah thaJeztah closed this Feb 12, 2021
@thaJeztah thaJeztah reopened this Feb 12, 2021
@thaJeztah
Copy link
Member

yup, that looks to work

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 12, 2021

Build succeeded.

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 41e3057 into containerd:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants