New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references to Windows 20H2 test images. #5025
Conversation
Hi @jeremyje. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like you forgot to sign-off the commit (it's missing a signed-off-by
line in the commit message); https://github.com/containerd/project/blob/master/CONTRIBUTING.md#sign-your-work
Signed-off-by: Jeremy Edwards <1312331+jeremyje@users.noreply.github.com>
Build succeeded.
|
Hmm.. looks like there's some flakiness in other tests (at least, doesn't look related to this PR);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
@jeremyje: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How do I trigger that test to run again? |
/retest |
1 similar comment
/retest |
@jeremyje "Re-run jobs" can be used for restarting GHA https://docs.github.com/en/actions/managing-workflow-runs/re-running-a-workflow (I already clicked the button) |
@AkihiroSuda I think that's only available for users with write access; at least, button doesn't show for me; |
🤦♂️ Then the only available option would be to amend the commit message slightly and push... |
Let me try if closing/re-opening still works as a workaround. |
yup, that looks to work |
Build succeeded.
|
LGTM |
No description provided.