Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestRuntimeHandler logging #5033

Merged
merged 1 commit into from Feb 18, 2021
Merged

Fix TestRuntimeHandler logging #5033

merged 1 commit into from Feb 18, 2021

Conversation

chrisfregly
Copy link
Contributor

Resolving issue #5032:

  • An empty --runtime-handler flag results in testing against the default runtime so modified and removed logging to clarify.
  • Added a TODO for future work on potentially adding test(s) for multiple runtimes at the same time.

@k8s-ci-robot
Copy link

Hi @chrisfregly. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 12, 2021

Build succeeded.

@chrisfregly
Copy link
Contributor Author

/cc @mikebrow

@mikebrow
Copy link
Member

/ok-to-test

mikebrow
mikebrow reviewed Feb 15, 2021
View reviewed changes
integration/runtime_handler_test.go Outdated
assert.Equal(t, *runtimeHandler, sbStatus.RuntimeHandler)

t.Logf("Verify runtimeService.ListPodSandbox sets RuntimeHandler")
t.Logf("Verify runtimeService.ListPodSandbox sets runtimeHandler")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`runtimeService.ListPodSandbox() returns...'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above ^

mikebrow
mikebrow reviewed Feb 15, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, thx.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 16, 2021

Build succeeded.

4 similar comments
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 16, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 16, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 16, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 16, 2021

Build succeeded.

mikebrow
mikebrow approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Member

fuweid commented Feb 18, 2021

@chrisfregly would you squash commits? The change is small. Thanks

@chrisfregly
fix: issue #5032
80e1d98 
Signed-off-by: Chris Fregly <cfregly@ibm.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 18, 2021

Build succeeded.

@chrisfregly
Copy link
Contributor Author

Commits have been squashed. Thanks for reviewing

estesp
estesp approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a98c83c into containerd:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chrisfregly @k8s-ci-robot @mikebrow @fuweid @cpuguy83 @estesp