Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.16.1 #5056

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Update to Go 1.16.1 #5056

merged 1 commit into from
Mar 11, 2021

Conversation

estesp
Copy link
Member

@estesp estesp commented Feb 19, 2021 •
edited

Update to Go 1.16.1 release

Signed-off-by: Phil Estes estesp@amazon.com

@dims
Copy link
Member

dims commented Feb 19, 2021

/test all

@dims
Copy link
Member

dims commented Feb 19, 2021

/test pull-containerd-build
/test pull-containerd-node-e2e

1 similar comment
@estesp
Copy link
Member Author

estesp commented Feb 19, 2021

/test pull-containerd-build
/test pull-containerd-node-e2e

@estesp
Copy link
Member Author

estesp commented Feb 19, 2021

@dims not sure how to figure out the e2e failure as it appears containerd isn't running (the socket file does not exist), but I don't see any errors explaining why it isn't..

@dims
Copy link
Member

dims commented Feb 19, 2021

@estesp from this log

Feb 19 18:10:40 tmp-node-e2e-d927e36f-ubuntu-gke-1804-1-16-v20200330 configure.sh[1805]: ++ echo master:e58be59cbded3dcadaf67164fdc37eb52afed66c,5056:e541b9b6d2f3649959bc050ab90566c4c9139278
Feb 19 18:10:40 tmp-node-e2e-d927e36f-ubuntu-gke-1804-1-16-v20200330 configure.sh[1805]: + deploy_dir=9773450dd82256b5520199d7cca8396adb2e727d
Feb 19 18:10:40 tmp-node-e2e-d927e36f-ubuntu-gke-1804-1-16-v20200330 configure.sh[1805]: + deploy_path=cri-containerd-staging/9773450dd82256b5520199d7cca8396adb2e727d
Feb 19 18:10:40 tmp-node-e2e-d927e36f-ubuntu-gke-1804-1-16-v20200330 configure.sh[1805]: ++ curl -f --ipv4 --retry 6 --retry-delay 3 --silent --show-error https://storage.googleapis.com/cri-containerd-staging/9773450dd82256b5520199d7cca8396adb2e727d/latest
Feb 19 18:10:40 tmp-node-e2e-d927e36f-ubuntu-gke-1804-1-16-v20200330 configure.sh[1805]: curl: (22) The requested URL returned error: 404
Feb 19 18:10:40 tmp-node-e2e-d927e36f-ubuntu-gke-1804-1-16-v20200330 configure.sh[1805]: + version=

@AkihiroSuda
Copy link
Member

/test pull-containerd-node-e2e

AkihiroSuda
AkihiroSuda approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if green)

@AkihiroSuda
Copy link
Member

/test pull-containerd-node-e2e

1 similar comment
@AkihiroSuda
Copy link
Member

/test pull-containerd-node-e2e

@AkihiroSuda AkihiroSuda added this to the 1.5 milestone Feb 25, 2021
@estesp
Copy link
Member Author

estesp commented Feb 25, 2021

/test pull-containerd-build

@estesp
Copy link
Member Author

estesp commented Feb 25, 2021

/test pull-containerd-node-e2e

@containerd containerd deleted a comment from k8s-ci-robot Feb 25, 2021
@containerd containerd deleted a comment from k8s-ci-robot Feb 25, 2021
@containerd containerd deleted a comment from theopenlab-ci bot Feb 25, 2021
@containerd containerd deleted a comment from k8s-ci-robot Feb 25, 2021
@containerd containerd deleted a comment from theopenlab-ci bot Feb 25, 2021
@estesp
Copy link
Member Author

estesp commented Feb 25, 2021

@dims any ideas? originally the problem was that the wrong bucket was being looked in because I added a commit between the "working" pull-containerd-build and the failing ..node-e2e runs; after fixing that I'm now getting:

Start Test Suite on Host tmp-node-e2e-483a515e-cos-81-12871-1245-10
timeout: failed to run command './ginkgo': Permission denied

Seems now that we aren't running CRI tests regularly post-merge maybe things are getting stale--we probably need to find some actions magic to trigger node-e2e tests on any commits that change CRI code or just run it daily via actions cron?

@dims
Copy link
Member

dims commented Feb 26, 2021

/test pull-containerd-node-e2e

going to try one last time to see if the gingko permission problem still persists. i don't think it will work as the underlying issue i saw in #5056 (comment) is still there. will dig into this more today

@dims
Copy link
Member

dims commented Feb 26, 2021

failed : curl -f --ipv4 --retry 6 --retry-delay 3 --silent --show-error https://storage.googleapis.com/cri-containerd-staging/6f7489c0425b8b1f95d833592598f037fc138745/latest is failing
succeeded : curl -f --ipv4 --retry 6 --retry-delay 3 --silent --show-error https://storage.googleapis.com/cri-containerd-staging/containerd/6f7489c0425b8b1f95d833592598f037fc138745/latest

Looks like we introduced a containerd directory and forgot to update the script?

@dims
Copy link
Member

dims commented Feb 26, 2021

screen shot from https://storage.googleapis.com/cri-containerd-staging/ :
image

@estesp estesp changed the title DRAFT: Update to Go 1.16 Update to Go 1.16 Mar 3, 2021
@estesp estesp marked this pull request as ready for review March 3, 2021 21:46
@AkihiroSuda AkihiroSuda added the cherry-pick/1.4.x Change to be cherry picked to release/1.4 branch label Mar 4, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 5, 2021

Build succeeded.

@AkihiroSuda AkihiroSuda mentioned this pull request Mar 9, 2021
Closed
thaJeztah
thaJeztah approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar
Copy link
Member

kevpar commented Mar 9, 2021

Looks like go1.16.1 comes out tomorrow. Probably makes sense to wait and update to that?

@estesp
Copy link
Member Author

estesp commented Mar 10, 2021

@kevpar agreed; it's out but actions env hasn't updated their config file yet.. usually within 24 hours. As soon as it's available I'll update the PR

@estesp
Update to Go 1.16.1
c55492f 
Signed-off-by: Phil Estes <estesp@amazon.com>
@estesp estesp changed the title Update to Go 1.16 Update to Go 1.16.1 Mar 11, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 11, 2021

Build succeeded.

dims
dims approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 381cbdd into containerd:master Mar 11, 2021
@mikebrow
Copy link
Member

whoot ... time to move up local development environment to go 1.16.1!

@estesp estesp deleted the go-1.16 branch March 11, 2021 15:07
@estesp estesp removed the cherry-pick/1.4.x Change to be cherry picked to release/1.4 branch label Mar 12, 2021
@estesp
Copy link
Member Author

estesp commented Mar 12, 2021

Removed the cherry pick since we now have #5178 after the quick turnaround of another Go point release.

@thaJeztah thaJeztah mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@estesp @dims @AkihiroSuda @kevpar @mikebrow @thaJeztah