Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci: fix superfluous slice operations #5064

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Feb 23, 2021

Signed-off-by: Iceber Gu wei.cai-nat@daocloud.io

@k8s-ci-robot
Copy link

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Iceber
Copy link
Member Author

Iceber commented Feb 23, 2021

@fuweid PTAL, Thanks

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 23, 2021

Build succeeded.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@fuweid
Copy link
Member

fuweid commented Feb 23, 2021

@Iceber, your change is not related to the failed case. I still am working on the case. Sorry for that inconvenient.

@Iceber
Copy link
Member Author

Iceber commented Feb 23, 2021

@Iceber, your change is not related to the failed case. I still am working on the case. Sorry for that inconvenient.

Thanks

@Iceber Iceber closed this Feb 24, 2021
@Iceber Iceber reopened this Feb 24, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 24, 2021

Build succeeded.

@crosbymichael
Copy link
Member

crosbymichael commented Feb 25, 2021

restarting ci after we merged in the fix. If this still fails, can you rebase your branch?

@estesp
Copy link
Member

estesp commented Feb 25, 2021

This will need a rebase on master to get the perms fix for /etc/ CNI dir

Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@Iceber
Copy link
Member Author

Iceber commented Feb 25, 2021

@crosbymichael @estesp rebased

@mxpv mxpv merged commit 46c9746 into containerd:master Feb 26, 2021
@Iceber Iceber deleted the fix-redundant-slice branch February 26, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants