-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oci: fix superfluous slice operations #5064
Conversation
Hi @Iceber. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fuweid PTAL, Thanks |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
@Iceber, your change is not related to the failed case. I still am working on the case. Sorry for that inconvenient. |
Thanks |
Build succeeded.
|
restarting ci after we merged in the fix. If this still fails, can you rebase your branch? |
This will need a rebase on master to get the perms fix for /etc/ CNI dir |
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
414653e
to
f7f6aab
Compare
@crosbymichael @estesp rebased |
Signed-off-by: Iceber Gu wei.cai-nat@daocloud.io