Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update linuxkit readme #5088

Merged
merged 1 commit into from
Mar 1, 2021
Merged

update linuxkit readme #5088

merged 1 commit into from
Mar 1, 2021

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Feb 25, 2021

Although linuxkit/kubernetes has not been updated for a long time

@k8s-ci-robot
Copy link

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Member

/ok-to-test

mikebrow
mikebrow reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see suggested edits

contrib/linuxkit/README.md Outdated
@@ -1,5 +1,8 @@
# LinuxKit Kubernetes project

The LinuxKit [`projects/kubernetes`](https://github.com/linuxkit/linuxkit/tree/master/projects/kubernetes) subdirectory contains a project to build master and worker node virtual machines. When built with `KUBE_RUNTIME=cri-containerd` then these images will use `cri-containerd` as their execution backend.
The [linuxkit/kubernetes](https://github.com/linuxkit/kubernetes) can build master and worker node virtual machines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest:

The [LinuxKit](https://github.com/linuxkit/kubernetes) is a project for building os images for kubernetes master and worker node virtual machines.

contrib/linuxkit/README.md Outdated

See the [project README](https://github.com/linuxkit/linuxkit/blob/master/projects/kubernetes/README.md).
When built with `KUBE_RUNTIME=cri-containerd` then these images will use `cri-containerd` as their execution backend.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest:

When the images are built with cri-containerd as the KUBE_RUNTIME option they will use `cri-containerd` as their execution backend.

@Iceber
Copy link
Member Author

Iceber commented Feb 26, 2021

@mikebrow updated. Thanks

@Iceber Iceber requested a review from mikebrow February 26, 2021 02:00
@Iceber Iceber closed this Feb 26, 2021
@Iceber Iceber reopened this Feb 26, 2021
@Iceber
Copy link
Member Author

Iceber commented Feb 26, 2021

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@Iceber
Copy link
Member Author

Iceber commented Feb 26, 2021

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@Iceber
update linuxkit readme
ba19912 
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 1, 2021

Build succeeded.

fuweid
fuweid approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 54a63a3 into containerd:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

@mikebrow mikebrow Awaiting requested review from mikebrow

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Iceber @k8s-ci-robot @mikebrow @estesp @fuweid