Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update BUILDING.md #5106

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Mar 2, 2021

Signed-off-by: Iceber Gu wei.cai-nat@daocloud.io

@k8s-ci-robot
Copy link

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 2, 2021

Build succeeded.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see path nit

BUILDING.md Show resolved Hide resolved
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 3, 2021

Build succeeded.

@Iceber Iceber requested a review from mikebrow March 3, 2021 01:57
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow changed the title update BUILDMING.md update BUILDING.md Mar 5, 2021
@mikebrow mikebrow merged commit a72fe7d into containerd:master Mar 5, 2021
@Iceber Iceber deleted the update-building-readme branch March 6, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants