Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deflake TestRestartMonitor #5157

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

AkihiroSuda
Copy link
Member

Fix #5146

Fix containerd#5146

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 11, 2021

Build succeeded.

@AkihiroSuda
Copy link
Member Author

CI failure is unrelated

Run vagrant up --provision-with=selinux,install-runc,test-integration
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'fedora/33-cloud-base' version '33.20201019.0' is up to date...
==> default: Running provisioner: install-runc (shell)...
    default: Running: inline script
    default: /tmp/vagrant-install-runc: line 5: GOPATH: unbound variable

https://github.com/containerd/containerd/pull/5157/checks?check_run_id=2083879992

@k8s-ci-robot
Copy link

@AkihiroSuda: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-containerd-node-e2e ee84e85 link /test pull-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 8634cd9 into containerd:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test: TestRestartMonitor
4 participants