Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exported comments enforcer in CI #5180

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fix exported comments enforcer in CI #5180

merged 2 commits into from
Mar 15, 2021

Conversation

dmcgowan
Copy link
Member

Add comments where missing and fix incorrect comments

@containerd containerd deleted a comment from theopenlab-ci bot Mar 12, 2021
@containerd containerd deleted a comment from k8s-ci-robot Mar 12, 2021
@dmcgowan
Fix exported comments enforcer in CI
35eeb24 
Add comments where missing and fix incorrect comments

Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
Fix unsupported files exporting functions for apparmor and seccomp
8cf669c 
Signed-off-by: Derek McGowan <derek@mcg.dev>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 12, 2021

Build succeeded.

estesp
estesp approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

mikebrow
mikebrow approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
very nice

@mikebrow
Copy link
Member

You have reached your pull rate limit.

sigh

@estesp
Copy link
Member

estesp commented Mar 12, 2021

@thaJeztah actually seems like the macos instances don't dump any identifier; seems like only the Linux hosts, so we have nothing to go on: https://pipelines.actions.githubusercontent.com/G4SighzWVVZ6vsyiz7FFMFjLjRzveJHseEnVyibkSq87Cl2x4O/_apis/pipelines/1/runs/4118/signedlogcontent/64?urlExpires=2021-03-12T17%3A42%3A14.7222002Z&urlSigningMethod=HMACV1&urlSignature=HSjFqaYg9yGT0FHgi1L0hvT1BjNqY%2BiDzBQUmGqWKLk%3D

thaJeztah
thaJeztah approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I hate it that they disable it by default

@thaJeztah
Copy link
Member

@thaJeztah actually seems like the macos instances don't dump any identifier; seems like only the Linux hosts, so we have nothing to go on: https://pipelines.actions.githubusercontent.com/G4SighzWVVZ6vsyiz7FFMFjLjRzveJHseEnVyibkSq87Cl2x4O/_apis/pipelines/1/runs/4118/signedlogcontent/64?urlExpires=2021-03-12T17%3A42%3A14.7222002Z&urlSigningMethod=HMACV1&urlSignature=HSjFqaYg9yGT0FHgi1L0hvT1BjNqY%2BiDzBQUmGqWKLk%3D

Arf.. that's a pity 😞
Let me check anyway if there's other ways to find out if there's machines missing in the list

@thaJeztah thaJeztah mentioned this pull request Mar 12, 2021
Merged
@estesp estesp merged commit a113818 into containerd:master Mar 15, 2021
@dmcgowan dmcgowan deleted the lint-enforce-comments branch March 23, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmcgowan @mikebrow @estesp @thaJeztah