-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/v2/runc: fix the defer cleanup of the NewContainer #5206
Conversation
Hi @Iceber. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Build succeeded.
|
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
86ceac2
to
5e484c9
Compare
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fuweid Is it necessary to fix release/1.4? This looks useful for the previous version. |
yeah. please |
The cleanup operation does not take effect in many cases
e.g.
containerd/runtime/v2/runc/container.go
Lines 112 to 116 in 2755ead
containerd/runtime/v2/runc/container.go
Lines 130 to 132 in 2755ead
containerd/runtime/v2/runc/container.go
Lines 143 to 152 in 2755ead