Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/containerd/zfs v0.0.0-20210322090317-0e92c2247fb7 (for snapshot usage) #5243

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

AkihiroSuda
Copy link
Member

Contains "Implements zfs usage by returning the USED field from the zfs snapshot"
(containerd/zfs#38)

@AkihiroSuda AkihiroSuda added this to the 1.5 milestone Mar 22, 2021
Contains "Implements zfs usage by returning the USED field from the zfs snapshot"
(containerd/zfs#38)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title go.mod: github.com/containerd/zfs v0.0.0-20210322044354-7427b788480e go.mod: github.com/containerd/zfs v0.0.0-20210322090317-0e92c2247fb7 Mar 22, 2021
@AkihiroSuda AkihiroSuda changed the title go.mod: github.com/containerd/zfs v0.0.0-20210322090317-0e92c2247fb7 go.mod: github.com/containerd/zfs v0.0.0-20210322090317-0e92c2247fb7 (for snapshot usage) Mar 22, 2021
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalbani
Copy link

dalbani commented Mar 22, 2021

Question from a total newbie on containerd's release process: I suppose this fix can't / won't be backported to the 1.4 branch?
I'm asking because this fix would be more than welcome in MicroK8s, which will use containerd 1.4.x for the next MicroK8s 1.21 release.

@dmcgowan
Copy link
Member

@dalbani zfs is supported in 1.4 so this would be a backport-able change. I believe that would require backporting in the zfs repo as well to exclude non-backported changes when vendoring into the 1.4 branch.

@dmcgowan dmcgowan merged commit edf6484 into containerd:master Mar 22, 2021
@dalbani
Copy link

dalbani commented Mar 23, 2021

@dmcgowan
Shall I then open a feature request regarding my wish to have this function backported to 1.4?

@thaJeztah
Copy link
Member

I believe that would require backporting in the zfs repo as well to exclude non-backported changes when vendoring into the 1.4 branch.

Diff between version used in 1.4 and this version; containerd/zfs@9abf673...0e92c22. At a glance, most changes look "ok" (so probably wouldn't require containerd/zfs to branch for 1.4); only change that requires local changes (afaics) is this commit: containerd/zfs@804f3e0 (containerd/zfs#31) (would depend on cherry-picking 96f4ce4 #4534)

@dalbani
Copy link

dalbani commented Mar 24, 2021

Thanks @thaJeztah for this detailed report! Let me know if I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants