-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: github.com/containerd/zfs v0.0.0-20210322090317-0e92c2247fb7 (for snapshot usage) #5243
Conversation
Contains "Implements zfs usage by returning the USED field from the zfs snapshot" (containerd/zfs#38) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
fca015a
to
8cdc1f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Question from a total newbie on containerd's release process: I suppose this fix can't / won't be backported to the 1.4 branch? |
@dalbani zfs is supported in 1.4 so this would be a backport-able change. I believe that would require backporting in the zfs repo as well to exclude non-backported changes when vendoring into the 1.4 branch. |
@dmcgowan |
Diff between version used in 1.4 and this version; containerd/zfs@9abf673...0e92c22. At a glance, most changes look "ok" (so probably wouldn't require containerd/zfs to branch for 1.4); only change that requires local changes (afaics) is this commit: containerd/zfs@804f3e0 (containerd/zfs#31) (would depend on cherry-picking 96f4ce4 #4534) |
Thanks @thaJeztah for this detailed report! Let me know if I can help. |
Contains "Implements zfs usage by returning the USED field from the zfs snapshot"
(containerd/zfs#38)