-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remotes/ctr: allow to limit max concurrent uploads like downloads #5260
remotes/ctr: allow to limit max concurrent uploads like downloads #5260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than a naming suggestion.
f7c3e09
to
391ad5f
Compare
cmd/ctr/commands/content/fetch.go
Outdated
@@ -109,7 +109,7 @@ type FetchConfig struct { | |||
Platforms []string | |||
// Whether or not download all metadata | |||
AllMetadata bool | |||
// RemoteOpts is not used by ctr, but can be used by other CLI tools | |||
// RemoteOpts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is now very laconic :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Also add flags for push/pull subcommand to limit max concurrent uploads/downloads. Signed-off-by: Wei Fu <fuweid89@gmail.com>
391ad5f
to
f8c2f04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also add flags for push/pull subcommand to limit max concurrent
uploads/downloads.
Signed-off-by: Wei Fu fuweid89@gmail.com