Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotes/ctr: allow to limit max concurrent uploads like downloads #5260

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Mar 24, 2021

Also add flags for push/pull subcommand to limit max concurrent
uploads/downloads.

Signed-off-by: Wei Fu fuweid89@gmail.com

Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a naming suggestion.

client.go Outdated Show resolved Hide resolved
@fuweid fuweid force-pushed the limit-concurent-uploads-when-push branch from f7c3e09 to 391ad5f Compare March 25, 2021 02:06
@@ -109,7 +109,7 @@ type FetchConfig struct {
Platforms []string
// Whether or not download all metadata
AllMetadata bool
// RemoteOpts is not used by ctr, but can be used by other CLI tools
// RemoteOpts
Copy link
Member

@mxpv mxpv Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is now very laconic :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Also add flags for push/pull subcommand to limit max concurrent
uploads/downloads.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid force-pushed the limit-concurent-uploads-when-push branch from 391ad5f to f8c2f04 Compare March 25, 2021 06:37
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 4f7d1d7 into containerd:master Mar 25, 2021
@fuweid fuweid deleted the limit-concurent-uploads-when-push branch April 14, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants