-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run unit tests on CI for MacOS #5264
Conversation
Though we don't officially support Apple platform, we should at least run unit tests to make sure things are not broken. Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Skipping CI for Draft Pull Request. |
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@@ -19,6 +19,7 @@ package server | |||
import ( | |||
"context" | |||
"path/filepath" | |||
goruntime "runtime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elsewhere in the codebase this is aliased as "gruntime".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than a naming suggestion
@@ -1,4 +1,4 @@ | |||
// +build !windows | |||
// +build !windows,!darwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what didn't work on Darwin for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- FAIL: TestBreakouts (9.18s)
--- FAIL: TestBreakouts/HardlinkSymlinkBeforeCreateTarget (8.78s)
tar_test.go:934: Failed to apply tar: link /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-027924874/localpasswd /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-027924874/localpasswd-dup: operation not permitted
--- FAIL: TestBreakouts/HardlinkSymlinkRelative (0.01s)
tar_test.go:934: Failed to apply tar: link /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-068255073/passwdlink /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-068255073/localpasswd: no such file or directory
--- FAIL: TestBreakouts/HardlinkSymlinkAbsolute (0.09s)
tar_test.go:934: Failed to apply tar: link /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-814375756/passwdlink /var/folders/nx/lmjd5hsx3r3gwyr3tgw14q140000gn/T/test-writer-to-tar-814375756/localpasswd: operation not permitted
FAIL
FAIL github.com/containerd/containerd/archive 13.724s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dive in a lot what exactly is wrong here, for now I just want to enable tests in general.
We can follow up with this to run more tests.
Though we don't officially support Macs, we should at least run unit tests
to make sure things are not broken on this platform.
Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com