remove mirrors from default; document the deprecation of registry.configs and registry.mirrors #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebrow
force-pushed
the
cri-registry-doc-updates
branch
from
88d8240
to
645b251
Compare
|
Build succeeded.
|
|
Not sure a question here is appropriate, is there alternative in |
see example here showing a set of hosts for a given default namespace.. chatting it up with derek the idea is config_path/host_namespace/hosts.toml so config_path/gcr.io/hosts.toml and config_path/docker.io/hosts.toml |
mikebrow
force-pushed
the
cri-registry-doc-updates
branch
from
645b251
to
106a3df
Compare
|
Build succeeded.
|
mikebrow
force-pushed
the
cri-registry-doc-updates
branch
from
106a3df
to
0158932
Compare
|
Build succeeded.
|
mikebrow
changed the title
mikebrow
force-pushed
the
cri-registry-doc-updates
branch
from
a37825f
to
5238a0a
Compare
|
Build succeeded.
|
cpuguy83
reviewed
Apr 5, 2021
mikebrow
force-pushed
the
cri-registry-doc-updates
branch
from
5238a0a
to
25d03f6
Compare
|
Build succeeded.
|
mikebrow
force-pushed
the
cri-registry-doc-updates
branch
from
25d03f6
to
ed5948f
Compare
|
Build succeeded.
|
|
/test pull-containerd-node-e2e |
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
mikebrow
force-pushed
the
cri-registry-doc-updates
branch
from
ed5948f
to
f9bcf4a
Compare
|
rebased to pick up the re-enabled cri tests |
|
Build succeeded.
|
dims
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean up of the docs around registry config.
A fix to remove old style mirrors config from the default config. Without the fix init will report
WARN[2021-04-07T09:21:29.773381274-05:00] failed to load plugin io.containerd.grpc.v1.cri error="invalid plugin config:mirrorscannot be set whenconfig_pathis provided"Signed-off-by: Mike Brown brownwm@us.ibm.com