Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the 404 link in docs/cri/config.md #5307

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

maoyangLiu
Copy link
Contributor

I find the link in docs/cri/config.md is outdate,so I fix it.

@k8s-ci-robot
Copy link

Hi @maoyangLiu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 5, 2021

Build succeeded.

@ktock
Copy link
Member

ktock commented Apr 5, 2021

- FAIL - does not have a valid DCO

sign your commit please.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 6, 2021

Build succeeded.

@ktock
Copy link
Member

ktock commented Apr 8, 2021

Also, please squash the commits.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 8, 2021

Build succeeded.

@ktock
Copy link
Member

ktock commented Apr 13, 2021

@maoyangLiu Could you rebase it on the latest master?
This will solve the CI flakiness.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 13, 2021

Build succeeded.

Signed-off-by: maoyangLiu <liumaoyang@inspur.com>
@maoyangLiu
Copy link
Contributor Author

open again

@maoyangLiu maoyangLiu reopened this Apr 13, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 13, 2021

Build succeeded.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your first contribution!

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 2305f05 into containerd:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants