Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-cni-release: add imgcrypt binaries (v1.1.0) #5308

Merged
merged 1 commit into from
Apr 7, 2021
Merged

cri-cni-release: add imgcrypt binaries (v1.1.0) #5308

merged 1 commit into from
Apr 7, 2021

Conversation

AkihiroSuda
Copy link
Member

Add ctd-decoder and ctr-enc.

Close #5265

@AkihiroSuda AkihiroSuda mentioned this pull request Apr 5, 2021
Closed
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 5, 2021

Build succeeded.

@AkihiroSuda
Copy link
Member Author

Interesting CI failure

 failed to pull image: rpc error: code = Unknown desc = failed to pull and unpack image "gcr.io/cri-tools/test-image-tag:all": failed to copy: httpReadSeeker: failed open: unexpected status code https://gcr.io/v2/cri-tools/test-image-tag/blobs/sha256:2d4bd5735ff286d2879cfb24a6f284a174c470f10e5d21adc4427c6bbc2c2c36: 403 Forbidden

@mikebrow
Copy link
Member

mikebrow commented Apr 5, 2021

Interesting CI failure

 failed to pull image: rpc error: code = Unknown desc = failed to pull and unpack image "gcr.io/cri-tools/test-image-tag:all": failed to copy: httpReadSeeker: failed open: unexpected status code https://gcr.io/v2/cri-tools/test-image-tag/blobs/sha256:2d4bd5735ff286d2879cfb24a6f284a174c470f10e5d21adc4427c6bbc2c2c36: 403 Forbidden

yeah .. gcr guys are looking into it..

mikebrow
mikebrow approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lumjjb
lumjjb approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fuweid
fuweid approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 6, 2021

Build succeeded.

@stefanberger
Copy link
Contributor

LGTM

@AkihiroSuda
cri-cni-release: add imgcrypt binaries (v1.1.0)
92ea98e 
Add `ctd-decoder` and `ctr-enc`.

Close issue 5265

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 7, 2021

Build succeeded.

estesp
estesp approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit b527273 into containerd:master Apr 7, 2021
@AkihiroSuda AkihiroSuda mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanberger stefanberger stefanberger left review comments

@estesp estesp estesp approved these changes

@lumjjb lumjjb lumjjb approved these changes

@mikebrow mikebrow mikebrow approved these changes

@fuweid fuweid fuweid approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ctd-decoder to cri-containerd-cni-<VERSION>-<OS>-<ARCH>.tar.gz
6 participants
@AkihiroSuda @mikebrow @stefanberger @estesp @lumjjb @fuweid