-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: github.com/Microsoft/hcsshim v0.8.16 #5326
Conversation
Build succeeded.
|
Looks like test cleanup failed on Windows due to a layer issue. Any idea if we've seen that in CI recently? |
Hmm.. not sure; I recall #5133 was merged recently (which I think was to fix that?) |
full diff: microsoft/hcsshim@v0.8.15...v0.8.16 also updating github.com/Microsoft/hcsshim/test to current master Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Build succeeded.
|
The CI failure was due to
I did some testing and this seems to be another error case that the cleanup needs to handle. I've pushed #5328 to address this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ForceRemoveAll has special logic on Windows for cleaning up a Windows snapshotter directory. The logic was missing proper handling for an error case that can be returned in some cases. This fixes the CI failure seen in containerd#5326. Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
ForceRemoveAll has special logic on Windows for cleaning up a Windows snapshotter directory. The logic was missing proper handling for an error case that can be returned in some cases. This fixes the CI failure seen in containerd#5326. Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
full diff: microsoft/hcsshim@v0.8.15...v0.8.16
also updating github.com/Microsoft/hcsshim/test to current master