Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address recent runtimes config confusion #5342

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

mikebrow
Copy link
Member

the following config issue
https://github.com/kubernetes/kubernetes/pull/100992/files

shows we needed more help in the error messaging

Signed-off-by: Mike Brown brownwm@us.ibm.com

@mikebrow mikebrow requested a review from dims April 12, 2021 18:56
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 12, 2021

Build succeeded.

@mikebrow mikebrow force-pushed the improve-error-out-for-bad-config branch from 9db183b to 4ab3aef Compare April 12, 2021 19:21
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 12, 2021

Build succeeded.

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@mikebrow mikebrow force-pushed the improve-error-out-for-bad-config branch from 4ab3aef to 8a04bd0 Compare April 12, 2021 20:33
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 12, 2021

Build succeeded.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 68ee827 into containerd:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants