Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker resolver to authorize redirects #5504

Merged
merged 1 commit into from May 17, 2021

Conversation

dmcgowan
Copy link
Member

Allows redirects to be authorized if authorization is provided for the redirected to host. The authorization will always go to the redirect and never to the referrer.

Matches redirect logic done by Docker today.

Fixes #5503

Allows redirects to be authorized if authorization is provided
for the redirected to host. The authorization will always go
to the redirect and never to the referrer.

Signed-off-by: Derek McGowan <derek@mcg.dev>
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 14, 2021

Build succeeded.

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit bf1a667 into containerd:master May 17, 2021
@mikebrow mikebrow added the cherry-pick/1.5.x Change to be cherry picked to release/1.5 branch label May 17, 2021
@thaJeztah thaJeztah added cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch and removed cherry-pick/1.5.x Change to be cherry picked to release/1.5 branch labels Jul 20, 2021
breakings added a commit to breakings/packages that referenced this pull request Aug 8, 2021
The ninth patch release for containerd 1.4 updates runc to 1.0.1 and contains
other minor updates.

### Notable Updates

- **Update runc binary to 1.0.1** [#5751](containerd/containerd#5751)
- **Update pull authorization logic on redirect** [#5504](containerd/containerd#5504)
- **Fix user agent used for fetching registry authentication tokens** [#5761](containerd/containerd#5761)
@dmcgowan dmcgowan deleted the fix-authorization-on-redirect branch April 20, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pull image from public registry nabo.codimd.dev
7 participants