Add proper Go version before project checks #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in Go, the go.mod file cannot declare a version of Go above the installed `go version`; until the default Go version in GitHub actions virt environments is 1.16, we have to install 1.16 before running the project checks now. Signed-off-by: Phil Estes <estesp@amazon.com>
estesp
added
the
cherry-pick/1.5.x
|
Not setting cherry pick label for |
|
Lucky me; this PR even tested the change as I was placed on a 0606 env. image :) |
|
Build succeeded.
|
This was referenced Jun 10, 2021
estesp
added
cherry-picked/1.5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in Go, the go.mod file cannot declare a version of Go
above the installed
go version; until the default Go version in GitHubActions virtual environments is 1.16 or above, we have to install 1.16 before
running the project checks now.
More details: golang/go#46143
The 20210606 version of virtenv ubuntu-18.04 is still rolling out so I have only seen this fail one PR build in the last 24 hours, but we should get this change in before it starts breaking all PR runs once rollout of the new virt. env. image is complete.
Signed-off-by: Phil Estes estesp@amazon.com