Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang plugin package dependency requires 1.8 #564

Merged
merged 1 commit into from Feb 24, 2017
Merged

golang plugin package dependency requires 1.8 #564

merged 1 commit into from Feb 24, 2017

Conversation

mikebrow
Copy link
Member

Minor update to README.md to mention the 1.8 requirement.. otherwise one will receive the following build error:

mike@mike-VirtualBox:~/go/src/github.com/docker/containerd$ make binaries
馃惓 bin/ctr
plugin.go:6:2: cannot find package "plugin" in any of:
	/home/mike/go/src/github.com/docker/containerd/vendor/plugin (vendor tree)
	/usr/local/go/src/plugin (from $GOROOT)
	/home/mike/go/src/plugin (from $GOPATH)

Signed-off-by: Mike Brown brownwm@us.ibm.com

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@codecov-io
Copy link

Codecov Report

Merging #564 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   62.12%   62.12%           
=======================================
  Files           3        3           
  Lines         404      404           
=======================================
  Hits          251      251           
  Misses         93       93           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 660783c...6eb6bf7. Read the comment docs.

@stevvooe
Copy link
Member

LGTM

@stevvooe stevvooe merged commit d377454 into containerd:master Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants