-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.5 backport] Allow expanded DNS configuration #5893
Conversation
Hi @gjkim42. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can we cherry-pick this to release/1.5? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this is reasonable to backport to release/1.5
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will have to merge #5894 to get CI working in |
5df7602
to
cdbdcbd
Compare
Build succeeded.
|
cdbdcbd
to
3665639
Compare
Signed-off-by: Gunju Kim <gjkim042@gmail.com>
3665639
to
27e1646
Compare
Build succeeded.
|
rebased. thanks :) |
Cherry pick of #5878 on release/1.5.
#5878: Allow expanded DNS configuration