Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.5] Fix dir support for devices #5941

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

alexandref75
Copy link
Contributor

Backport to 1.5: Fix dir support for devices #5845

@k8s-ci-robot
Copy link

Hi @alexandref75. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 3, 2021

Build succeeded.

@estesp estesp changed the title Release/1.5 [release/1.5] Fix dir support for devices Sep 3, 2021
@estesp
Copy link
Member

estesp commented Sep 3, 2021

Is this a backport or did you cherry-pick the commits from main to release/1.5? If they can be cherry-picked we like to use the -x flag so the origin commit is listed in the commit entry.

If you didn't cherry-pick and had to backport we usually put that in the title; e.g. [release/1.5] backport: {original PR title}

@alexandref75
Copy link
Contributor Author

I use cherry-pick. I will redo it using the -x flag.

Signed-off-by: Alexandre Peixoto Ferreira <alexandref75@gmail.com>
(cherry picked from commit 7fba862)
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 3, 2021

Build succeeded.

Signed-off-by: Alexandre Peixoto Ferreira <alexandref75@gmail.com>
(cherry picked from commit 838afd2)
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 7, 2021

Build succeeded.

Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 36d09a4 into containerd:release/1.5 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants