Register healtcheck service before calling restore() #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estesp
approved these changes
Mar 7, 2017
containerd/main.go
Outdated
| if len(listenParts) != 2 { | ||
| return fmt.Errorf("bad listen address format %s, expected proto://address", listenSpec) | ||
| } | ||
| // Register server early to allow healtcheck to be done |
There was a problem hiding this comment.
minor spelling nit: "healthcheck"
mlaventure
force-pushed
the
register-healtcheck-sooner
branch
from
c7c4687
to
e9f35a2
Compare
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
mlaventure
force-pushed
the
register-healtcheck-sooner
branch
from
e9f35a2
to
7783966
Compare
|
LGTM @tonistiigi any comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com
--
This ensures that a client (e.g.
dockerd) doesn't assume thatcontainerdis dead if restoring containers takes more than its timeout value (currently 3secs fordockerd)Should help address moby/moby#31479