Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc health check service #623

Merged
merged 1 commit into from Mar 14, 2017

Conversation

hqhq
Copy link
Contributor

@hqhq hqhq commented Mar 13, 2017

Fixes: #615

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

@codecov
Copy link

codecov bot commented Mar 13, 2017

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   65.49%   65.49%           
=======================================
  Files           3        3           
  Lines         455      455           
=======================================
  Hits          298      298           
  Misses         95       95           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a132a88...e663cbd. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

@@ -341,6 +344,9 @@ func serveGRPC(server *grpc.Server) error {
if err := os.Chown(path, conf.GRPC.Uid, conf.GRPC.Gid); err != nil {
return err
}
healthServer := health.NewServer()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it a Service plugin for consistency?

Fixes: containerd#615

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq
Copy link
Contributor Author

hqhq commented Mar 14, 2017

@mlaventure Updated.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure
Copy link
Contributor

@hqhq uh, actually can you change the commit message to something more useful? Like "containerd: add healtcheck grpc service" or similar?

@ijc
Copy link
Contributor

ijc commented Mar 14, 2017

This is adding a service to check the health of the gRPC endpoints/services, as opposed to adding a container healthcheck, right?

@mlaventure
Copy link
Contributor

@ijc25 correct. This is to grpc service to check that containerd is still responding/running.

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit a85c28d into containerd:master Mar 14, 2017
@hqhq hqhq deleted the add_healthcheck_service branch March 15, 2017 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants