New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc health check service #623
Conversation
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 65.49% 65.49%
=======================================
Files 3 3
Lines 455 455
=======================================
Hits 298 298
Misses 95 95
Partials 62 62 Continue to review full report at Codecov.
|
LGTM |
cmd/containerd/main.go
Outdated
@@ -341,6 +344,9 @@ func serveGRPC(server *grpc.Server) error { | |||
if err := os.Chown(path, conf.GRPC.Uid, conf.GRPC.Gid); err != nil { | |||
return err | |||
} | |||
healthServer := health.NewServer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it a Service plugin for consistency?
Fixes: containerd#615 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
8866acb
to
e663cbd
Compare
@mlaventure Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hqhq uh, actually can you change the commit message to something more useful? Like "containerd: add healtcheck grpc service" or similar? |
This is adding a service to check the health of the gRPC endpoints/services, as opposed to adding a container healthcheck, right? |
@ijc25 correct. This is to grpc service to check that containerd is still responding/running. |
LGTM |
Fixes: #615
Signed-off-by: Qiang Huang h.huangqiang@huawei.com