fix multi-arch Windows image preference #6696
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frederik Siegmund siegmund@slb.com
Changes in platforms/defaults_windows.go:
Multi-arch windows with UBR matching host UBR will be preferred
Change sorting logic of multi-arch image. Images that exactly match host OS version will be moved to the top, followed by versions that match host build, in descending order.
See #6693
The image with exact host version will be preferred. Otherwise as logic above.
Description for the changelog
fix multi-arch Windows image preference
Note: This fix was first submitted to Moby. On recommendation from thaJeztah I implemented the same fix for containerd.