Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi-arch Windows image preference #6696

Closed

Conversation

fsiegmund
Copy link

Signed-off-by: Frederik Siegmund siegmund@slb.com

  • What I did

Changes in platforms/defaults_windows.go:

Multi-arch windows with UBR matching host UBR will be preferred

Change sorting logic of multi-arch image. Images that exactly match host OS version will be moved to the top, followed by versions that match host build, in descending order.

  • How to verify it

See #6693

The image with exact host version will be preferred. Otherwise as logic above.

Description for the changelog
fix multi-arch Windows image preference

Note: This fix was first submitted to Moby. On recommendation from thaJeztah I implemented the same fix for containerd.

Signed-off-by: Frederik Siegmund <siegmund@slb.com>
@k8s-ci-robot
Copy link

Hi @fsiegmund. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 18, 2022

Build succeeded.

@fsiegmund fsiegmund closed this Mar 18, 2022
@fsiegmund fsiegmund deleted the fsiegmund-multiarchfixwindows branch March 18, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants