Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.5] remove empty go mod to allow building for go 1.18 #6716

Merged
merged 2 commits into from Mar 23, 2022
Merged

[release/1.5] remove empty go mod to allow building for go 1.18 #6716

merged 2 commits into from Mar 23, 2022

Conversation

thaJeztah
Copy link
Member

No description provided.

@thaJeztah
[release/1.5] remove empty go mod to allow building for go 1.18
86bec21 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@samuelkarp
Copy link
Member

Looks like there are still issues?

 go: downloading github.com/stevvooe/protobuild v0.2.0
go get: github.com/stevvooe/protobuild@v0.1.0 updating to
	github.com/stevvooe/protobuild@v0.2.0: parsing go.mod:
	module declares its path as: github.com/containerd/protobuild
	        but was required as: github.com/stevvooe/protobuild

@thaJeztah
Copy link
Member Author

why is it getting 0.2.0? 🤔

I guess it was renamed in between 🥺

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 23, 2022

Build succeeded.

@thaJeztah
Copy link
Member Author

I pushed a commit; hopefully that helps

@thaJeztah
Copy link
Member Author

Looks like something may be broken there as well in go modules (as I don't think it should not switch to a version that was renamed 😞)

@thaJeztah
Copy link
Member Author

AAAARGH

It's not a breaking change; it's tooling, and it's by design 🤬🤬🤬🤬

 go get' is no longer supported outside a module.

	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation

@thaJeztah
install-dev-tools: use go install, and pin by version
a2d10ac 
the github.com/stevvooe/protobuild@v0.1.0 module was renamed to
github.com/containerd/protobuild, but go modules ignores the
rename and pulls v0.2.0 (which is after the rename)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

okay; new attempt

@thaJeztah
Copy link
Member Author

ah; one more to fix (cri-deps has the same issue)

@k8s-ci-robot
Copy link

@thaJeztah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerd-build a2d10ac link true /test pull-containerd-build
pull-containerd-node-e2e a2d10ac link true /test pull-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dmcgowan dmcgowan merged commit 09920a0 into containerd:release/1.5 Mar 23, 2022
@thaJeztah thaJeztah deleted the 1.5_remove_empty_mod branch March 23, 2022 19:25
@kzys kzys mentioned this pull request May 4, 2022
Closed
@copybara-service copybara-service bot mentioned this pull request Oct 13, 2022
Closed
copybara-service bot pushed a commit to google/gvisor that referenced this pull request Oct 13, 2022
@ayushr2 @gvisor-bot
Update containerd tests to use versions 1.5.11 and 1.6.2.
e2d5663 
These versions are compatible with Go 1.18. There are a lot of OSS bugs
about this issue. Notable discussions:
- golang/go#51285
- containerd/containerd#6586

This was fixed upstream in the main branch in containerd/containerd#6605.
The fix was back-ported to v1.5 and v1.6 in containerd/containerd#6716
and containerd/containerd#6717 respectively.

These backports are available in the following versions:
```shell
/tmp/gopathJJGZf/containerd$ git tag --contains 765df66099eec88d0365eaa1e9a933877a058f0b
v1.6.2
v1.6.3
v1.6.4
v1.6.5
v1.6.6
v1.6.7
v1.6.8
/tmp/gopathJJGZf/containerd$ git tag --contains 86bec213720b54bf9ea2813e2c2a577271af58d3
v1.5.11
v1.5.12
v1.5.13
```

So use the smallest versions out of them.

PiperOrigin-RevId: 480965567
cavcrosby added a commit to cavcrosby/homelab-cm that referenced this pull request Oct 12, 2023
@cavcrosby
Migrate Poseidon k8s cluster nodes to Debian 12
00f942c 
A local containerd deb package will be built using a Docker image
because the respective version of the containerd deb package distributed
by Debian's snapshot repositories does not work with my Poseidon
Kubernetes cluster.

The go tool now used as part of my Makefile will not need to be tied to
a specific version of Golang. The only requirement is that the Golang
version installed supports go modules.

The sed commands are required to allow for building containerd with
Golang versions '1.18'+. This fix follows how upstream patched this, see
containerd/containerd#6716.

pyyaml will now be added to the k8s_controllers client Python virtual
environment because the debian/bookworm64 Vagrant box does not ship with
a 'yaml' library installed in its system Python environment, causing the
'Add the Calico Helm repository' task to fail. Hence also why
ansible_python_interpreter is now set for the
'Setup Kubernetes control planes (first control-planes) (poseidon)'
play.

The entire /etc/containerd directory is being removed as part of the
'Remove the default Debian packaged containerd configuration file' task
because the containerd deb package installs a single configuration file
within that directory. I could have just removed the file but I did not
want to leave an empty directory on the filesystem.

The 'Register the current grub configuration file inode' task now
requires elevated permissions because the grub configuration file is not
readable by the ansible_user. The
'Remove preset Vagrant box configurations' play was removed because the
play was only applicable when using the generic/ubuntu2204 Vagrant box
for the k8s_workers and k8s_controllers.

gawk was changed to awk because gawk is not installed on the
debian/bookworm64 Vagrant box, and I am fine with using mawk
implementation.

gnupg was added as a package to install as part of the Kubernetes apt
repository dependencies because the gpg tool is not installed by default
on the debian/bookworm64 Vagrant box. This should have been added as
part of 966ad96 because that's when the roles started using said tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @samuelkarp @k8s-ci-robot @dmcgowan