-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.5] Upgrade Go to 1.17 and golangci-lint #6719
Conversation
The GitHub Action is unstable especially on Windows (see containerd#6618). This change may not address the issue itself, but using the latest version makes reporting the upstream the issue easier. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com> (cherry picked from commit 622a35a) Signed-off-by: Derek McGowan <derek@mcg.dev>
@@ -1,3 +1,4 @@ | |||
//go:build !windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is still on go1.16, so looks like these changes must be reverted 😞
Error: File is not `gofmt`-ed with `-s` (gofmt)
Error: File is not `gofmt`-ed with `-s` (gofmt)
Error: File is not `gofmt`-ed with `-s` (gofmt)
Not sure which file this is complaining about though 😞 let me try running it locally
Warning: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
Warning: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
e2ada75
to
db21cdf
Compare
@dmcgowan this looks to be the one for the error-message;
|
db21cdf
to
bc4c147
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
fab5aad
to
7f03aea
Compare
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+433 −4,951
Wow.
LGTM though.
Backport of #6666