New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update runc binary and vendor to v1.1.2 #6934
Conversation
This is the second patch release of the runc 1.1 release branch. It fixes CVE-2022-29162, a minor security issue (which appears to not be exploitable) related to process capabilities. This is a similar bug to the ones found and fixed in Docker and containerd recently (CVE-2022-24769). - A bug was found in runc where runc exec --cap executed processes with non-empty inheritable Linux process capabilities, creating an atypical Linux environment. For more information, see GHSA-f3fp-gc8g-vw66 and CVE-2022-29162. - runc spec no longer sets any inheritable capabilities in the created example OCI spec (config.json) file. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
no changes in vendored code Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Hmmm... fun... another vanity URL down?
|
curl -v 'https://go.opentelemetry.io/otel/exporters/otlp/internal/retry?go-get=1'
* Trying 216.239.32.21:443...
* Connected to go.opentelemetry.io (216.239.32.21) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server accepted to use h2
* Server certificate:
* subject: CN=go.opentelemetry.io
* start date: Mar 25 19:42:58 2022 GMT
* expire date: Jun 23 19:42:57 2022 GMT
* subjectAltName: host "go.opentelemetry.io" matched cert's "go.opentelemetry.io"
* issuer: C=US; O=Google Trust Services LLC; CN=GTS CA 1D4
* SSL certificate verify ok.
* Using HTTP2, server supports multiplexing
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0x7f8ed780a600)
> GET /otel/exporters/otlp/internal/retry?go-get=1 HTTP/2
> Host: go.opentelemetry.io
> user-agent: curl/7.79.1
> accept: */*
>
< HTTP/2 200
< content-type: text/html; charset=utf-8
< vary: Accept-Encoding
< cache-control: public, max-age=86400
< x-cloud-trace-context: 1b899b1203f005b031200201b0e4659d;o=1
< date: Thu, 12 May 2022 12:36:46 GMT
< server: Google Frontend
< content-length: 765
<
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<meta name="go-import" content="go.opentelemetry.io/otel git https://github.com/open-telemetry/opentelemetry-go">
<meta name="go-source" content="go.opentelemetry.io/otel https://github.com/open-telemetry/opentelemetry-go https://github.com/open-telemetry/opentelemetry-go/tree/master{/dir} https://github.com/open-telemetry/opentelemetry-go/blob/master{/dir}/{file}#L{line}">
<meta http-equiv="refresh" content="0; url=https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/internal/retry">
</head>
<body>
Nothing to see here; <a href="https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/internal/retry">see the package on pkg.go.dev</a>.
</body>
* Connection #0 to host go.opentelemetry.io left intact
</html>⏎ |
Or is this a circular import issue? |
I think it's just a flaky HTTP connection; the "connection reset by peer" happens more regularly than I would like to see with git clones, go mod activity, etc. during CI. I restarted just that test to see if it was just a flaky HTTP connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Looks green now; for a bit I wondered if it was a misconfigured redirect (from the curl output) 😅 |
This is the second patch release of the runc 1.1 release branch. It
fixes CVE-2022-29162, a minor security issue (which appears to not be
exploitable) related to process capabilities.
This is a similar bug to the ones found and fixed in Docker and
containerd recently (CVE-2022-24769).
non-empty inheritable Linux process capabilities, creating an atypical Linux
environment. For more information, see GHSA-f3fp-gc8g-vw66 and CVE-2022-29162.
example OCI spec (config.json) file.