Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing closed HTTP Body #7107

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

wzshiming
Copy link
Contributor

@wzshiming wzshiming commented Jun 28, 2022

Need to close the body when the status is not 200,
otherwise, this resource will not be released.

@k8s-ci-robot
Copy link

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>
@fuweid fuweid added the easy-to-review Easy to review label Jun 28, 2022
@fuweid fuweid added this to New in Code Review via automation Jun 28, 2022
@fuweid fuweid moved this from New to Ready For Review in Code Review Jun 28, 2022
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 36bd4a5 into containerd:main Jun 28, 2022
Code Review automation moved this from Ready For Review to Done Jun 28, 2022
@wzshiming wzshiming deleted the fix/close-http-body branch June 29, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-to-review Easy to review
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants