-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.6] go.mod: Bump hcsshim to v0.9.4 #7200
Conversation
close+re-open to kick off CI |
Linux test failures are definitely unrelated, but if anyone can re-kick them off I'd appreciate it. @thaJeztah I'm going to open up a series of commits against main to upgrade to the same tag as this PR |
^^ PR to main was opened and merged; #7212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CGroupsV2 and I are in a constant feud |
Rerunning |
hmm, the Cgroups v2 failure is potentially an interesting package version inter-dependency problem? Looks like |
Trying #7217 since the only difference now is that |
Thanks Phil, it seems like CI passed for that PR |
Gonna rebase to bring in that fedora bump |
This tag contains some fixes for hostprocess containers, mainly around fixing task stats which regressed from a change in v0.9.3. https://github.com/microsoft/hcsshim/releases/tag/v0.9.4 Signed-off-by: Daniel Canter <dcanter@microsoft.com>
41182ef
to
0007f40
Compare
Still failed, but now it actually got past the preamble before even running the tests and failed on a port forward test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This tag contains some fixes for hostprocess containers, mainly around
fixing task stats which regressed from a change in v0.9.3.
https://github.com/microsoft/hcsshim/releases/tag/v0.9.4