Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] go.mod: Bump hcsshim to v0.9.4 #7200

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

dcantah
Copy link
Member

@dcantah dcantah commented Jul 23, 2022

This tag contains some fixes for hostprocess containers, mainly around
fixing task stats which regressed from a change in v0.9.3.

https://github.com/microsoft/hcsshim/releases/tag/v0.9.4

go.mod Show resolved Hide resolved
@dcantah dcantah closed this Jul 25, 2022
@dcantah dcantah reopened this Jul 25, 2022
@dcantah
Copy link
Member Author

dcantah commented Jul 25, 2022

close+re-open to kick off CI

@dcantah
Copy link
Member Author

dcantah commented Jul 25, 2022

Linux test failures are definitely unrelated, but if anyone can re-kick them off I'd appreciate it. @thaJeztah I'm going to open up a series of commits against main to upgrade to the same tag as this PR

@thaJeztah
Copy link
Member

#7200 (comment)

This was "semi"-intentional for now as we were looking to move main to a 0.10.0-beta tag very shortly. v0.9.2 doesn't even have the code that introduced the regression so we should be fine in that regard. If we want to do the incremental move main to 0.9.4 first as well I'm fine with that, let me know

^^ PR to main was opened and merged; #7212

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcantah
Copy link
Member Author

dcantah commented Jul 26, 2022

CGroupsV2 and I are in a constant feud

@fuweid
Copy link
Member

fuweid commented Jul 26, 2022

CGroupsV2 and I are in a constant feud

Rerunning

@estesp
Copy link
Member

estesp commented Jul 26, 2022

hmm, the Cgroups v2 failure is potentially an interesting package version inter-dependency problem? Looks like crun is needing a specific function linkage in criu that isn't in the criu version installed? I'm not sure if this is a temporary issue with this specific mix of Fedora 35 and our scripts or something we need to fix specifically in release/1.6 (since we aren't seeing this particular failure in main)

@estesp
Copy link
Member

estesp commented Jul 26, 2022

Trying #7217 since the only difference now is that main has moved up to Fedora 36 as a base.

@dcantah
Copy link
Member Author

dcantah commented Jul 26, 2022

Thanks Phil, it seems like CI passed for that PR

@dcantah
Copy link
Member Author

dcantah commented Jul 26, 2022

Gonna rebase to bring in that fedora bump

This tag contains some fixes for hostprocess containers, mainly around
fixing task stats which regressed from a change in v0.9.3.

https://github.com/microsoft/hcsshim/releases/tag/v0.9.4

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah
Copy link
Member Author

dcantah commented Jul 26, 2022

Still failed, but now it actually got past the preamble before even running the tests and failed on a port forward test

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit d972571 into containerd:release/1.6 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants